Thomas Rast <trast@xxxxxxxxxxxxxxx> writes:
> But from the tests I get back
>
> dd: opening `/dev/stdin': No such file or directory
> error: git-fast-import died of signal 13
> not ok - 110 R: copy using cat-file
>
> In any case I cannot see a reason to use this construct: 'dd' reads
> from stdin by default, so you could just leave away the option.
Thanks for testing and reporting.
-- >8 --
Subject: t9300: remove unnecessary use of /dev/stdin
We really shouldn't be using these funny /dev/* files that did not exist
in V7 UNIX in our tests when we do not have to.
Output from
$ git grep -n -e /dev/ --and --not -e /dev/null t/
tells us that, aside from use of /dev/urandom in apache.conf used in http
tests, "dd if=/dev/stdin" added recently to t/t9300-fast-import.sh are the
only offenders, so removing them should be straightforward.
Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
---
t/t9300-fast-import.sh | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/t/t9300-fast-import.sh b/t/t9300-fast-import.sh
index d615d04..055ddc6 100755
--- a/t/t9300-fast-import.sh
+++ b/t/t9300-fast-import.sh
@@ -1794,7 +1794,7 @@ test_expect_success PIPE 'R: copy using cat-file' '
read blob_id type size <&3 &&
echo "$blob_id $type $size" >response &&
- dd if=/dev/stdin of=blob bs=$size count=1 <&3 &&
+ dd of=blob bs=$size count=1 <&3 &&
read newline <&3 &&
cat <<EOF &&
@@ -1845,7 +1845,7 @@ test_expect_success PIPE 'R: print blob mid-commit' '
EOF
read blob_id type size <&3 &&
- dd if=/dev/stdin of=actual bs=$size count=1 <&3 &&
+ dd of=actual bs=$size count=1 <&3 &&
read newline <&3 &&
echo
@@ -1880,7 +1880,7 @@ test_expect_success PIPE 'R: print staged blob within commit' '
echo "cat-blob $to_get" &&
read blob_id type size <&3 &&
- dd if=/dev/stdin of=actual bs=$size count=1 <&3 &&
+ dd of=actual bs=$size count=1 <&3 &&
read newline <&3 &&
echo deleteall
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html