Re: [PATCH] git-cherry.txt: Change symbol marks in graph.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski venit, vidit, dixit 02.12.2010 09:00:
> Jari Aalto <jari.aalto@xxxxxxxxx> writes:
> 
>> From: Jari Aalto <jari.aalto@xxxxxxxxx>
>>
>> The common commit were marked with a minus sign (-), but that is
>> usually interpreted as something less or substracted. Use natural
>> equal sign (=). Commits that are not in upstream were marked with plus
>> sign (+) but a question mark (?) is visually a litle more striking
>> (erect) in context where all other signs are "flat". It also helps
>> visually impared to see difference between (* ... ?) as opposed to
>> similar signs (* ... +).
> 
> Reading comprehension FAIL.  The graph in question uses '+' and '-' because
> that is what 'git cherry' *output( uses ('+' included, '-' excluded).  They
> are very natural in git-cherry output (diff-like).

Yep, and I so wished that git-cherry had different output that I even
saw a git-cherry patch where there was none...

So, +1 from me if this comes with an actual code patch.

Michael

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]