On Tue, Nov 30, 2010 at 1:30 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> writes: > >> Signed-off-by: Giuseppe Bilotta <giuseppe.bilotta@xxxxxxxxx> >> --- >> Documentation/CodingGuidelines | 6 ++++++ >> 1 files changed, 6 insertions(+), 0 deletions(-) >> >> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines >> index 5aa2d34..7ecce51 100644 >> --- a/Documentation/CodingGuidelines >> +++ b/Documentation/CodingGuidelines >> @@ -31,6 +31,12 @@ But if you must have a list of rules, here they are. >> >> For shell scripts specifically (not exhaustive): >> >> + - We use tabs for indentation. > > Ok. > >> + - The choices in case ... esac statement are not indented with respect >> + to the the case and esac lines. The body of the choices however _is_ >> + indented (by one tab). >> + > > Nit; "choices" are called "case arms". I'll rephrase. > I don't think there is any need to emphasize your surprise that case body > is indented with "however _is_", which implies "against common sense or > normal convention" or somesuch. The thing is, there is no single _right_ > convention, and we want people to folow the one just picked---we should > just describe what it is without being emotional nor emphatic. Good point, I'll resend with a shorter commit message. Would you be ok with me adding an example, or do you think it's unnecessary? -- Giuseppe "Oblomov" Bilotta -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html