Re: [PATCH/RFC 2/3] diffstat: Use new diff.stat config values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthew Ruffalo <mmr15@xxxxxxxx> writes:

> From f3ca8d4222776fb38a2def4fb9c4691c09c1e0fd Mon Sep 17 00:00:00 2001
> From: Matthew Ruffalo <matthew.ruffalo@xxxxxxxx>
> Date: Sun, 28 Nov 2010 14:44:00 -0500
> Subject: [PATCH 2/3] diffstat: Use new diff.stat config values

Please drop these lines --- I can see them in the header of your e-mail.

> Previously, the diffstat width could only be specified with the
> command-line options '--width' and '--name-width'. This patch adds
> support for config file options 'diff.stat.width' and
> 'diff.stat.namewidth'.

In general, the second level in a three-level configuration variable name
is to choose which one of unbound set of things to set the value for, and
the last level of a configuration variable name is to name the specific
property to affect (e.g. "difftool.<tool>.path" "remote.<name>.url").

So this sounds more like "diffstat.width" and "diffstat.namewidth".  There
is no set of "<something>" that share "namewidth" property to warrant the
name "diff.<something>.namewidth".

The idea of the patch is good.  But the message is heavily whitespace
damaged and cannot be applied.  Please check the settings of your MUA.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]