Re: gitweb: false base href sent when integrated via reverse proxy and path_info is active

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 28, 2010 at 5:27 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> Hi Jakub et al,
>
> Daniel Reichelt wrote[1]:
>
>> I just noticed that integrating gitweb via reverse proxy is impossible when
>> path_info is enabled in gitweb.conf. The base href sent on gitweb.cgi:3427
>> contains the "internal" URL called by the reverse proxy mechanism, not the
>> original one called by the user agent which makes it impossible for the
>> client to display CSS, images, etc...
>>
>> I suggest an additional config variable, e.g.
>> $feature{'pathinfo'}{'basehrefoverride'} which could override the base href
>> tag determinted by the cgi script (or disable sending a base href tag at all
>> - at least I was able to achieve my desired setup by adjusting the URLs for
>> CSS etc in gitweb.conf to fitting absolute URLs).
>
> Any advice for Daniel?  Is it a good idea?

I'm not familiar with the way reverse proxies operate. Is there some
information that the script can scrape to understand that its request
is being reverse-proxied? Or are there options that the reverse
proxies can be configured with to pretend that the URL is not being
rewritten? These would be better solutions.

Lacking that, a plain

our $base_url  = 'whatever';

in the gitweb config should probably work, as the gitweb config is
evaluated _after_ the internal URI variables are set. Can the bug
submitter confirm that this does indeed work?

-- 
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]