Re: [PATCH] entry.c: remove "checkout-index" from error messages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 28, 2010 at 11:36:38AM +0700, Nguyán ThÃi Ngác Duy wrote:

> Back then when entry.c was part of checkout-index (or checkout-cache
> at that time [1]). It makes sense to print the command name in error
> messages. Nowadays entry.c is in libgit and can be used by any
> commands, printing "git checkout-index: blah" does no more than
> confusion. The error messages without it still give enough information.
> 
> [1] 12dccc1 (Make fiel checkout function available to the git library - 2005-06-05)
> 
> Signed-off-by: Nguyán ThÃi Ngác Duy <pclouds@xxxxxxxxx>
> ---
>  I attempted to replace "git checkout-index" with the actual command name
>  when these functions are called, but I think it's better just removing
>  it...

Agreed. This came up recently in another thread[1], and I also tracked
it down to a simple cut-and-paste from the original checkout-index.

Acked-by: Jeff King <peff@xxxxxxxx>

-Peff

[1] http://article.gmane.org/gmane.comp.version-control.git/160751
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]