Ãvar ArnfjÃrà Bjarmason wrote: > On Fri, Oct 29, 2010 at 00:08, Yann Dirson <ydirson@xxxxxxxxxx> wrote: >> +    slash = memrchr(src, '/', len); > > I can't compile pu now on Solaris due to this bit. Are you planning on > picking up the patch / configure / Makefile detection discussed in the > "[PATCH] compat: add memrchr()" thread? Just wondering what the > progress was on that. BTW, remember that the configure / Makefile detection is only an extra nicety. [1] teaches git to rely on the system memrchr on glibc systems only; on other systems (unless they define memrchr as a macro, which would be a strange thing to do), gitmemrchr is used. Upshot: it should be safe to use [1] without the configure / Makefile support. Later, an interested person can write a patch for improved memrchr[2] on *BSD and Plan 9. Jonathan [1] http://thread.gmane.org/gmane.comp.version-control.git/159081/focus=159121 [2] Lower code size. Maybe faster. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html