Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > +static void parse_checkpoint(void) > +{ > + do_checkpoint(); > skip_optional_lf(); > } I would have expected the new implementation of parse_checkpoint() to just set the checkpoint_requested variable to true, so that the checkpoint always happens in the main loop, which somehow feels cleaner. But that is a minor point. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html