Re: [PATCH] t/t9001-send-email.sh: fix '&&' chain in some tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Antonio Ospite wrote:

> --- a/t/t9001-send-email.sh
> +++ b/t/t9001-send-email.sh
> @@ -261,10 +262,10 @@ test_expect_success $PREREQ 'Author From: in message body' '
> test_expect_success $PREREQ 'Author From: in message body' '
> 	clean_fake_sendmail &&
> 	git send-email \
> 		--from="Example <nobody@xxxxxxxxxxx>" \
>  		--to=nobody@xxxxxxxxxxx \
>  		--smtp-server="$(pwd)/fake.sendmail" \
>  		$patches &&
> -	sed "1,/^\$/d" < msgtxt1 > msgbody1
> +	sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
>  	grep "From: A <author@xxxxxxxxxxx>" msgbody1
>  '
[...]
>  		$patches &&
> -	sed "1,/^\$/d" < msgtxt1 > msgbody1
> +	sed "1,/^\$/d" < msgtxt1 > msgbody1 &&
[...]
> @@ -300,5 +300,5 @@ test_expect_success $PREREQ 'Invalid In-Reply-To' '
>  		$patches \
> -		2>errors
> +		2>errors &&

Good.

> @@ -574,7 +574,7 @@ EOF
>  "
>  
>  test_expect_success $PREREQ '--suppress-cc=sob' '
> -	git config --unset sendemail.cccmd
> +	git config --unset sendemail.cccmd &&

This one needs a test_might_fail in front, since "git config --unset"
would fail if some future change causes the configuration item not to
be set in the first place.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]