On Thu, 18 Nov 2010, Junio C Hamano wrote: > Jakub Narebski <jnareb@xxxxxxxxx> writes: > > > That means adding GITWEBLIBDIR for future testing of individual > > modules (it was not present in v7.1). > > You confused me. "git grep" after test-applying this 4-patch series on > top of next shows only one GITWEBLIBDIR, which means that the symbol is > defined but nobody pays attention to it. That's why I wrote "for _future_ testing"... but perhaps it is not worth introducing it now that it is not yet used by any test. > > diff --git a/gitweb/Makefile b/gitweb/Makefile > > index 0a6ac00..f9e32eb 100644 > > --- a/gitweb/Makefile > > +++ b/gitweb/Makefile > > @@ -57,6 +57,7 @@ PERL_PATH ?= /usr/bin/perl > > ... > > -.PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE > > +.PHONY: all clean install install-modules test test-installed .FORCE-GIT-VERSION-FILE FORCE > > > > In the earlier series, 478da52 (gitweb: Prepare for splitting gitweb, > 2010-10-30) removed the trailing blank line from here but this does not do > so anymore, which is a micronit regression. I was not sure if such "while at it" style improvements are encouraged or not. Will remember it for v7.3. -- Jakub Narebski Poland -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html