Re: [PATCHv7.2 4/4] gitweb: Minimal testing of gitweb caching

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jakub Narebski <jnareb@xxxxxxxxx> writes:

> +gitweb_enable_caching () {
> +	test_expect_success 'enable caching' '
> +		cat >>gitweb_config.perl <<-\EOF &&
> +		our $caching_enabled = 1;
> +		our $minCacheTime = 60*60*24*7*30;     # very long expiration time for tests (a month)

Does your month have 210 days in it?

> +		our $maxCacheTime = 60*60*24*7*30*365; # upper bound for dynamic (adaptive) caching

Likewise, is this 210 years?  Does this bust 32-bit time_t somewhere?

> +		our $cachedir = "cache";               # for testsuite to clear the right thing
> +		# required, because otherwise some tests might intermittently not pass
> +		our $backgroundCache = 0; # should turn off cacheWaitForUpdate() / "Generating..."
> +		#our $cacheDoFork = 0;

leftover....

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]