Ãvar ArnfjÃrà Bjarmason <avarab@xxxxxxxxx> writes: > Change the builtin/*.c files and wt-status.c files which weren't using > builtin.h to use it, also remove any git-compat-util.h, strbuf.h and > cache.h from those files. We can trust on builtin.h including them. As I already said, buitlin/*.c is fine, but wt-status.c is very dubious. > This impeded my efforts to gettextize git, since I'd otherwise have to > add gettext.h to all of these. Using builtin.h is a good idea in any > case, since it's defining the prototypes for the cmd_* functions that > these files define. What about non-builtin commands? Don't they need to include gettext.h anyway? I would have expected that gettext.h would be included from cache.h, so that all gitty commands, whether they are builtin or standalone, have access to the symbols defined in it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html