Jonathan Nieder <jrnieder@xxxxxxxxx> writes: > The same code to check the position of HEAD is used by several > tests in this script. Factor it out as a function and simplify it. That rationale makes sense, but why use describe for it, especially if the helper is called "cmp-rev"? The tests here are not about catching breakages in describe. When we later want to move this helper to test-lib.sh, some potential callers may find it inconvenient that use of describe robs the ability to tell annotated tags from bare commits. > +test_cmp_rev () { > + git describe --always --tags "$1" >expect.rev && > + git describe --always --tags "$2" >actual.rev && > + test_cmp expect.rev actual.rev > +} -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html