Re: [PATCH 07/10] checkout: add -S to update sparse checkout

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/11/16 Miles Bader <miles@xxxxxxx>:
> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>>> +-S::
>>> +--update-sparse-checkout::
>>> + Â ÂAn editor is invoked to let you update your sparse checkout
>>> + Â Âpatterns. The updated patterns will be saved in
>>> + Â Â$GIT_DIR/info/sparse-checkout. The working directory is also
>>> + Â Âupdated. An empty file will abort the process.
>>
>> Wording nit: this doesn't make the worktree more up-to-date. ÂHow
>> about:
>>
>> Â--edit-sparse-checkout
>> Â--define-work-area
>> Â--narrow-worktree
>>
>> Hmph.
>>
>> --edit-sparse-checkout seems best for consistency of the choices I can
>> think of.
>
> "--change-sparse-checkout"?
>
> Onna-account of "edit" sounding like you're actually somehow editting
> the checkout itself... ÂOTOH, since it invokes the editor... hmmm
>
> BTW, wouldn't it be more convenient to allow specifying patterns
> directly via the command line? ÂI'd think in many (maybe the majority
> of) cases people will really only want one entry, and having to edit a
> file to specify it seems vaguely annoying...

A command line option to append patterns only sounds good to me. But
it would clutter up sparse-checkout file over time and may decrease
performance. The same option can also be reused for git-clone. Do you
suggest any name? I'm bad at naming.

I don't think I can make an option to remove patterns though.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]