Re: [PATCH] commit -s: allow "(cherry picked " lines in sign-off section

[Jay Soffian <jaysoffian@xxxxxxxxx>]

On Tue, Nov 16, 2010 at 5:52 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> I am not sure I agree with the reasoning of this patch, by the way. ÂA
> cherry-pick is an event that breaks the life of the patch, so it may even
> be a sensible thing to do to express "the above sign-off chain shows who
> were involved in the original commit; I am cherry-picking it out of
> context, and these people do not have much to do with the result" with a
> blank line on both sides of the "cherry picked" line, like this:
>
> Â Â Â ÂA concise summary of the change
>
> Â Â Â ÂA detailed description of the change, why it is needed, what
> Â Â Â Âwas broken and why applying this is the best course of action.
>
> Â Â Â ÂSigned-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> Â Â Â ÂSigned-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
>
> Â Â Â Â(cherry picked from commit 9d8117e72bf453dd9d85e0cd322ce4a0f8bccbc0)
>
> Â Â Â ÂSigned-off-by: Back Porter <backporter@xxxxxxxxxxx>

Or perhaps prefix them with Original-, inspired by email headers, and
which I think makes it even more clear that the sob lines don't apply
to the new commit.

 Â Â Â ÂOriginal-Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
 Â Â Â ÂOriginal-Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
        Cherry-picked-from: 9d8117e72bf453dd9d85e0cd322ce4a0f8bccbc0
 Â Â Â ÂSigned-off-by: Back Porter <backporter@xxxxxxxxxxx>

j.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html