Re: [PATCH 1/4] Makefile: move "Platform specific tweaks" above LIB_{H,OBJS}

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 15, 2010 at 17:11, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote:
> On Mon, Nov 15, 2010 at 08:07:08AM -0800, Junio C Hamano wrote:
>> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>>> Ãvar ArnfjÃrà Bjarmason wrote:
>
>>>> That listing should be in a comment at the start of the
>>>> Makefile. Please submit a patch for that!
>>>
>>> How about this? ÂAn annoying piece of GNU makefile syntax makes this
>>> uglier than it needs to be (search for HACK for details).
>>>
>>> Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
>>> ---
>>> diff --git a/Makefile b/Makefile
>>> index 1f1ce04..38edd65 100644
>>> --- a/Makefile
>>> +++ b/Makefile
>>> @@ -1,6 +1,8 @@
>>> Â# The default target of this Makefile is...
>>> Âall::
>>>
>>> +outline:: ; @echo "Configuration."
>>> +
>>> Â# Define V=1 to have a more verbose compile.
>>> Â#
>>> Â# Define SHELL_PATH to a POSIX shell if your /bin/sh is broken.
>>
>> Hmm, I don't quite get what you are trying to do here. ÂWhat good does the
>> output from "make outline" do to a potential/actual developer? ÂYou can
>> learn that there are sections for "Testing rules", but then what? ÂYou
>> will look for that string in the editor or pager.
>
> I dunno. ÂI wrote it because Ãvar asked for it (and to make visible
> where the trivial obstacles would lie in getting target-listing "make help"
> to work, which is more interesting to me).

I just meant that we should add your comment at the top at some point.

But doing it via something like outline is probably better in the long term.

But let's do it in another patch series :)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]