Re: [PATCH 002/160] Makefile: Set NO_GETTEXT=YesPlease on Windows & MinGW

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



(msysgit mailing list CC'ed)

On Sun, Nov 14, 2010 at 4:07 PM, Ævar Arnfjörð Bjarmason
<avarab@xxxxxxxxx> wrote:
> Change the Windows and MinGW build defaults to not build the gettext
> tools by default. Gettext hasn't yet been ported to the default
> environments on those systems, although Erik Faye-Lund is working on
> MinGW support.
>
> Reported-by: Johannes Sixt <j6t@xxxxxxxx>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>

I don't think this is exactly what Hannes reported; IIRC he reported
that setting NO_GETTEXT wasn't sufficient to get it to build. Just
unsetting NEEDS_LIBINTL for a platform that doesn't have gettext is
curing the symptoms rather than the decease, shouldn't the build
system and/or the code be fixed so setting NO_GETTEXT is sufficient
instead?

As a side-note, I think it might be time to merge the gettext-branch
into msysGit soon. If no one complains, I'll get it done one of the
next days.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]