On Sunday 14 November 2010, Jonathan Nieder wrote:
> Thiago Farina wrote:
> > On Tue, Nov 9, 2010 at 7:49 PM, Johan Herland <johan@xxxxxxxxxxx> wrote:
> >> die("confused: combine_notes_overwrite failed");
> >
> > This message looks like more a debug information. Could it be
> > rewritten to be more user friendly / more informative?
>
> Sverre mentioned the same thing. The intent is the same as the existing
>
> die("should not happen, someone must be hit on the forehead");
>
> --- i.e., to provoke bug reports if it happens, without the appearance
> of begging. :)
>
> So how about:
>
> die("BUG: combine_notes_overwrite failed");
>
> Something involving assert() could also work, but that tends to be
> a bit ugly.
Agreed. I've rewritten the die() messages in the following v6.1 patches.
...Johan
--
Johan Herland, <johan@xxxxxxxxxxx>
www.herland.net
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html