Bert Wesarg wrote: > On Sun, Nov 14, 2010 at 22:54, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: >> This sounds like an excellent sort of thing to add to git grep -O, too >> (which currently has very limited support for editors' line number >> features). ÂBut what will it do with typical non-git-specific setups >> like >> >> Â Â Â ÂVISUAL=vim >> >> or >> >> Â Â Â ÂEDITOR="gvim --nofork" >> >> ? >> >> Do existing editors support LINENUMBER in the environment? > > I don't expect this, I have a wrapper script around my editor to scan > the environment for these variables and pass the block/non-block > option to the editor. In that case, perhaps something like GIT_EDITOR=$(git var GIT_EDITOR) set -- --open-file-named-in-the-environment eval "$GIT_EDITOR" '"$@"' would be appropriate? This way, existing editors like vi, ed, and emacs fail: $ ed --fjdkaslfjdas ed: unrecognized option `--fjdkaslfjdas' rather than opening a new, empty file. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html