Re: [PATCH 003/160] gettext: fix bug in git-sh-i18n's eval_gettext() by using envsubst(1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Nov 14, 2010 at 20:15, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>> Nit: can this be moved to a subdir? ÂMaybe po or i18n, or even
>> envsubst. ÂThis could make it clearer that the code has an upstream
>> and should be updated when upstream is.
>
> IOW, just like "xdiff/" is a separate directory. ÂI think that is a sane
> thing to do.

Thanks for the suggestion. I'll put it in envsubst/ then.

Any idea about the issue of it being linked to too many things? I
tried to add another entry to this section:

    git-%$X: %.o $(GITLIBS)
        $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter
%.o,$^) $(LIBS)

    git-imap-send$X: imap-send.o $(GITLIBS)
        $(QUIET_LINK)$(CC) $(ALL_CFLAGS) -o $@ $(ALL_LDFLAGS) $(filter %.o,$^) \
            $(LIBS) $(OPENSSL_LINK) $(OPENSSL_LIBSSL)

But it wasn't actually used. But then again I don't know Makefile
hacking that much.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]