Re: [PATCH] gitweb: Time::HiRes is in core for Perl 5.8

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote:
> Jakub Narebski <jnareb@xxxxxxxxx> writes:
> 
> > Therefore there is no need to check if it is installed.  We can also
> > import gettimeofday and tv_interval.
> >
> > Signed-off-by: Jakub Narebski <jnareb@xxxxxxxxx>
> 
> I think "... and 'use 5.008' is at the begining of the script already, "

because gitweb requires Perl 5.8, in order to have good Unicode support.

> is missing before that "Therefore".  But otherwise it is a reasonable
> thing to do.
> 
> Thanks.

Would you amend commit message when applying it, then?
-- 
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]