Re: [PATCH] attr: support quoting pathname patterns in C style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Nov 8, 2010, at 10:40 AM, Junio C Hamano wrote:

> Kevin Ballard <kevin@xxxxxx> writes:
> 
>> Would this actually break any existing setups? The only ones that are affected
>> are ones beginning with ", which I imagine would be rather rare.
> 
> No regression policy means just that.  We try not to break "rather rare"
> people, only to add support for different kinds of "rather rare" setups,
> especially when the latter have working workarounds.

I'm still not convinced that the workaround is appropriate. If I have a file
named "file 1" that needs special attributes, then it is impossible to leave
those attributes unspecified for, e.g. "file.1". I'd have to set them on
"file 1" and then immediately unset them for "file.1". And as unspecified
behaves differently than unset, this can be a problem. Especially because if
I add any other files in the future that match "file?1" I have to remember
to go through gitattributes and re-set all of the ones already specified to
something appropriate for this file.

Sure, this is probably a rare case, but so is filenames beginning with a ".

Basically what I'm trying to say is, we already break one particular
"rather rare" setup. I would love to come up with a solution that supports
both setups, but I don't know if one exists outside of using a config
variable to control whether git attribute patterns support quoting (a solution
I am not particularly fond of for this case).

-Kevin Ballard--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]