Re: [PATCH 8/8] Remove pack file handling dependency from wrapper.o

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 06.11.2010 19:42, schrieb Jonathan Nieder:
> Renà Scharfe wrote:
> 
>> Ugh.  Having to remember setting this handler is tedious.
>>
>> Can it be set automatically once the first pack is loaded?  A quick look
>> suggests that use_pack() would be the right place to do it.
> 
> Maybe add_packed_git()?
> 
> use_pack() is called by:
> 
>  pack-objects::check_pack_inflate
>  pack-objects::copy_pack_data
>  pack-objects::check_object
>  check_pack_crc
>  verify_pack
>  get_size_from_delta
>  sha1_file::get_delta_base
>  sha1_file::unpack_object_header
>  packed_object_info_detail
>  sha1_file::unpack_compressed_entry
> 
> some of which would make me worry about thread-safety.

Possibly, but if that's the case then we have a thread-safety issue
already: use_pack() updates pack_mapped, which is used by
release_pack_memory() to see how much can be freed.  Just saying.

RenÃ
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]