Re: [PATCH v3] Porcelain scripts: Rewrite cryptic "needs update" error message

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:

> Ramkumar Ramachandra writes:
>> Although Git interally has the facility to differentiate between
>> porcelain and plubmbing commands and appropriately print errors,
>> several shell scripts invoke plubming commands triggering cryptic
>> plumbing errors to be displayed on a porcelain interface. This patch
>> replaces the "needs update" message in git-pull and git-rebase, when
>> `git update-index` is run, with a more friendly message.
>> 
>> Reported-by: Joshua Jensen <jjensen@xxxxxxxxxxxxxxxxx>
>> Reported-by: Thore Husfeldt <thore.husfeldt@xxxxxxxxx>
>> Signed-off-by: Ramkumar Ramachandra <artagnon@xxxxxxxxx>
>> ---
>>  Ref: <1285877017-8060-1-git-send-email-artagnon@xxxxxxxxx> for v2.
>>  Ref: <1285514516-5112-1-git-send-email-artagnon@xxxxxxxxx> for v1.
>> 
>>  Thanks to Matthieu for reviewing v1 and Junio for reviewing v2: I've
>>  tried to attack the problem more conservatively in this patch. It
>>  doesn't list paths, and doesn't print "generic" advice.
>
> Junio: Is this patch alright?

I did not see anything glaringly wrong in the patch offhand.  The new
messages look a bit too verbose, though.

Will queue and see what people would say.

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]