Hi, On Sat, Oct 30, 2010 at 7:46 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Breaks in a test assertion's && chain can potentially hide > failures from earlier commands in the chain. > > Commands intended to fail should be marked with !, test_must_fail, or > test_might_fail. ÂThe examples in this patch do not require that. > > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > --- > Hi, > > Just found some time to work through reports from the && checker. > The examples below only add && to the end of lines in various tests. > Passes all tests there (though of course that does not mean much). > > Thoughts? I haven't had a chance to look at this in detail, but this is really cool. Thanks for working on it. (And sorry for disappearing for over a month with some unfinished series; I'll try to update them this weekend.) Elijah -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html