2010/11/5 Eric Sunshine <ericsunshine@xxxxxxxxx>:
> On 11/4/2010 9:55 AM, Nguyán ThÃi Ngác Duy wrote:
>>
>> Full pattern must be quoted. So 'pat"t"ern attr' will give exactly
>> 'pat"t"ern', not 'pattern'. Also clarify that leading whitespaces are
>> not part of the pattern and document comment syntax.
>>
>> Signed-off-by: Nguyán ThÃi Ngác Duy<pclouds@xxxxxxxxx>
>> diff --git a/attr.c b/attr.c
>> index 6aff695..f3063d8 100644
>> --- a/attr.c
>> +++ b/attr.c
>> Â Â Â Âname = cp;
>> - Â Â Â namelen = strcspn(name, blank);
>> + Â Â Â if (*cp == '"') {
>> + Â Â Â Â Â Â Â if (unquote_c_style(&pattern, name,&ep))
>> + Â Â Â Â Â Â Â Â Â Â Â die("Broken attribute line: %s", line);
>
> The error message is perhaps a bit too generic, indicating only that
> _something_ on the line caused a problem. Mentioning that bad quoting of
> 'name' was at fault would help focus the user's attention where it is
> needed.
Really.
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html