Re: If merging that is really fast forwarding creates new commit [Was: Re: how to show log for only one branch]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Linus Torvalds wrote:

On Mon, 6 Nov 2006, Liu Yubao wrote:
Then, what bad *logical* problem will happen if a merging that is really a
fast forwarding creates a new commit?

You MUST NOT do that.

If a fast-forward were to do a "merge commit", you'd never get into the situation where two people merging each other would really ever get a stable result. They'd just keep doing merge commits on top of each other.
They can stop merging a fake commit with a real commit that point to same
tree object, here they reach a stable result: we have same tree content.

Git tracks history, not "your view of history". Trying to track "your view" is fundamentally wrong, because "your wiew" automatically means that the project history would not be distributed any more - it would be centralized around what _you_ think happened. That is not a sensible thing to have in a distributed system.
It's not my view, it's branch scope view, I can see how a branch evolves
relatively independently. In git, branch scope view is more or less neglected.
After fast forwarding merge, I can' tell where a branch come from -- I mean
the track of a branch.

If Junio publishes his reflog, I don't see what conflict will happen between
his local view (but now public, and naming it branch scope view seems more
sensible) and git's global view.

If this won't lead to problems, it seems also ok to use fake commit for
fast forwarding style merge, so we can follow HEAD^1 to travel through a
branch without reflog.

I hope I have expressed my thought clearly.

For example, the way to break the "infinite merges" problem above is to say that _you_ would be special, and you would do a "fast-forward commit", and the other side would always just fast-forward without a commit. But that is very fundamentally against the whole point of being distributed. Now you're special.
No one is special as everybody can create fake commit, any branch (almost
a tag) will never be overwritten to point to a commit object in
another branch, branches are relatively independent, that's to say
'git log' will reflect what has happened really in current branch (a CVS
semantical branch, not only a tag that always points to a tip commit).

In fact, even for "you", it would be horrible - because you personally might have 5 different repositories on five different machines. You'd have to select _which_ machine you want to track. That's simply insane. It's a totally broken model. (You can even get the same situation with just _one_ repository, by just having five different branches - you have to decide which one is the "main" branch).
What's the mean of upstream branch then? I have to know I should track
Junio's public repository.

When does one say two branches reach a common point? have same commit(must
point to same tree) or have same tree(maybe a fake commit and a real commit)?
I think git takes the first way.

Fast forwarding style merge tends to *automatically* centralize many
branches,  in CVS people merge two branches and drop side branch to
centralize them, they all have central semantics.
(I don't want to get flame war between CVS/SVN and GIT, I think
git is better than them really:-)

Besides, doing an empty commit like that ("I fast forwarded") literally doesn't add any true history information. It literally views history not as history of the _project_, but as the history of just one of the repositories. And that's wrong.
Something like 'git log --follow-all-parent' can show history of the project
as 'git log' does now.

So just get used to it. You MUST NOT do what you want to do. It's stupid.
Yes, I have understood the git way and am getting used to it, I like
its simple but powerful design and great efficiency, thank all for your
good work!

If you want to track the history of one particular local branch, use the "reflog" thing. It allows you to see what one of your local branches contained at any particular time.

See

	[core]
		logAllRefUpdates = true

Thanks, it's a pity I can't pull Junio's reflog :-(
documentation in "man git-update-refs" (and maybe somebody can write more about it?)

		Linus


-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]