Sverre Rabbelier wrote: > 2010/10/28 Nguyán ThÃi Ngác Duy <pclouds@xxxxxxxxx>: >> This series includes setup coverage tests (180/376 fail). Then the fixes, >> which bring down to zero failed test in the end. 02/42 describes the >> rules. New rules are: > > Shouldn't the fixes come first (for bisectability?). Good point. Ideally the tests would come first if the fixes are contraversial, or be squashed with the fixes if neither is contraversial, or after if the tests are contraversial but the fixes are not. For bisectability and clarity, the tests should use test_expect_failure when they fail (like this patch series does) and change that to test_expect_success in the patch that fixes them. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html