Re: [PATCH 08/10] user-manual.txt: explain better the remote(-tracking) branch terms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jonathan Nieder <jrnieder@xxxxxxxxx> writes:

>>  $ git branch -r
>>    origin/HEAD
>>    origin/html
>>    origin/maint
>>    origin/man
>>    origin/master
>>    origin/next
>>    origin/pu
>>    origin/todo
>>  ------------------------------------------------
>>
>> +In this case, "origin" is called a remote repository, or "remote" for
>> +short.
>
> "In this case" seems redundant (since we did not explain what other
> case it is being opposed to).

The wording was unfortunate, but what I meant was to explain the
example right above while defining the vocabulary.

I've changed it to "In this example".

>  The repository of origin is called a remote repository, or a "remote" for
>  short.
>
> would improve it?

It removes the link between the explanation and the example right
above. I prefer the quotes around "origin" to really show that it's
the string that appear in `git branch -r`.

>>         The branches of this repository are called "remote branches"
>> +from our point of view. The remote-tracking branches are created in
>> +the local repository at clone time, as a copy of the remote branches.
>
> Sentence structure.  Maybe
>
>           The branches of this repository are called "remote branches"
>   from our point of view. The remote-tracking branches listed above
>   were created based on the remote branches at clone time and will be
>   updated by "git fetch" and "git push".
>   See <<Updating -a-repository-With-git-fetch>> for details.

I've taken this (I like the "listed above" in particular), except I'm
keeping the (hence "git pull"), since "git pull" is probably more
likely to be used than "git fetch" by beginners.

>> +This command will fetch the changes from the remote branches to your
>> +remote-tracking branches `origin/*`, and merge default branch in the
>> +current branch.
>> +
>
> Article use.  Probably something like
>
> 	s/the changes/changes/
> 	s/merge default branch in/merge the default branch into/
>
> would do.

Taken, thanks.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]