Re: [PATCH] fetch-pack: make the ssh connection quiet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Oct 2010 11:24:29 -0400
Drew Northup <drew.northup@xxxxxxxxx> wrote:
> On Wed, 2010-10-27 at 16:27 +0200, Jan StÄpieÅ wrote:
> > The --quiet option passed to fetch-pack did not affect the ssh child
> > process. When an ssh server sent a motd it was displayed because the ssh
> > client wasn't launched with the -q option. This patch makes ssh run quietly
> > when fetch-pack is called with -q.
> > 
> > An analogous change should be made to other commands which accept --quiet
> > and connect to remotes using ssh.
> 
> I'm not so sure that's a good idea. Quoting from the (Open)SSH man page:
> 
> -q      Quiet mode.  Causes all warning and diagnostic messages to be suppressed.
> 
> Somehow I doubt that's what you intended or a good idea.

That's right, but according to the same source all fatal error messages
still get displayed. It's a question of how quiet should fetch-pack be
when --quiet is enabled.

Thanks for the comment,
-- 
Jan StÄpieÅ <jan@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]