Re: [PATCHv6 02/10] gitweb: git_get_heads_list accepts an optional list of refs.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/10/25 Jakub Narebski <jnareb@xxxxxxxxx>:
> On Sun, 24 Sep 2010, Giuseppe Bilotta wrote:
>
>>  sub git_get_heads_list {
>> -       my $limit = shift;
>> +       my ($limit, @classes) = @_;
>> +       unless (defined @classes) {
>> +               my $remote_heads = gitweb_check_feature('remote_heads');
>> +               @classes = ('heads', $remote_heads ? 'remotes' : ());
>> +       }
>
> defined(@array) is deprecated at t/../gitweb/gitweb.perl line 3221.
>
> Should be simply 'unless (@classes)', or 'unless (scalar @classes)' but
> conditionals provide boolean context, which is scalar context.
>
> I'm sorry about missing it earlier.

No problem. Fixed for the next batch.

-- 
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]