2010/10/25 Jakub Narebski <jnareb@xxxxxxxxx>:
> On Sun, 24 Oct 2010, Giuseppe Bilotta wrote:
>
>> When 'remotes' view is passed the 'hash' parameter, interpret it as the
>> name of a remote and limit the view the the heads of that remote.
>
> I don't quite like (ab)using 'hash' parameter like that, but because
> it allows us to use e.g. 'project.git/remotes/origin' path_info
> without writing special code for that, I am all right with this hack.
We could rename the 'hash' parameter to be more descriptive of the
fact that it includes this nature, but I really think it's not worth
it.
>> In single-remote view we let the user switch easily to the default
>> remotes view by specifying an -action_extra for the page header and by
>> enabling the 'remotes' link in the reference navigation submenu.
>
> Nice!
>
>> + if (defined $remote) {
>> + # only display the heads in a given remote
>
> It also strips uninteresting '<remote>/' prefix, isn't it?
> It would be nice, though not necessary, to have this in comment.
Good idea.
--
Giuseppe "Oblomov" Bilotta
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html