On Fri, 22 Oct 2010, Sverre Rabbelier wrote:
> Heya,
>
> On Fri, Oct 22, 2010 at 13:26, Nicolas Pitre <nico@xxxxxxxxxxx> wrote:
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â static int warned = 0;
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (!warned++)
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â warning("object %s cannot be read",
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â sha1_to_hex(src_entry->idx.sha1));
>
> How does this handle multiple missing objects? Will it only warn for
> the first one?
Yes, only the first one, so you have a bone to chase if that ever
happens to you. And that's good enough IMHO. Trying to warn for every
missing object would require extra storage per object to remember if any
particular object was warned for already, which is I think overkill for
an extremely unlikely event. Comprehensive reporting is the job of
fsck.
Nicolas