Kevin Ballard wrote: > On Oct 21, 2010, at 11:05 AM, Jonathan Nieder wrote: >> Bonus nit: does this belong in annotate-tests.sh or does it only apply >> to "git blame" and not "git annotate"? If the latter, a note in the >> commit message would be helpful. > > --show-email originally only applied to git-blame. I tweaked the > patch to make it apply to git-annotate simply because check_count > can't handle the format of git-blame, but the intention of the > change wasn't to make it apply to git-annotate in the first place. > You'll note I also didn't document it in the manpage for > git-annotate. If you think it's better to move it into > annotate-tests.sh, I can do that, but that does mean officially > declaring git-annotate as supporting --show-email. No preference, since I never use "git annotate" myself. In fact, long term, I'd rather see a "git blame --format=<template>" appearing and "git annotate" replaced with a thin script wrapping "git blame". Anyway, whatever you decide, it would be nice to document it in the commit message, no? e.g.: The tests and documentation only affect "git blame", because... -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html