Johan Herland wrote: > Allow combine_notes functions to request that a note be removed, > by setting the resulting note SHA1 to null_sha1 (0000000...). > > For consistency, also teach note_tree_insert() to skip insertion > of an empty note when there is no note to combine it with. I guess it's probably also worth clarifying that the term "empty note" means null_sha1 rather than empty_blob_sha1. i.e. something like: For consistency, also teach note_tree_insert() to skip insertion of an empty note (a note with val_sha1 equal to null_sha1) when there is no note to combine it with. The previous behavior iiuc would have been for write_notes_tree() to write invalid trees after such an operation. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html