Nguyen Thai Ngoc Duy wrote: > That. And simpler check. I mean "if (startup_info->help)" takes a tiny > bit less energy for me to understand than "if (argc == 2 && argv[1] == > "-h")". It's also good for grepping. Mm, that still does not motivate the churn to me. But "we can change the meaning to 'if (argc >= 2 && !strcmp(argv[1], "-h"))' some day" motivates it okay, I think. > 2010/10/20 Jonathan Nieder <jrnieder@xxxxxxxxx>: >> Maybe (modulo names) it would be better to do [...] > Can it be relaxed later when someone comes up with "--help-all" or something? Yes, I was just thinking out loud. By "relaxed" I meant the above (changing == to >= in one place). Now that I've thought it over, I don't mind startup_info->help so much. Hope that helps, and sorry for the noise. Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html