On Samstag, 16. Oktober 2010, Jonathan Nieder wrote:
> Saying "pack-objects died with strange error" after "pack-objects
> died of signal 13" seems kind of redundant. The latter was
> introduced when send-pack switched to the run-command API, which
> reports abnormal exits on behalf of the caller.
>
> Normal exits with nonzero status are not reported by run-command,
> though.
The rationale for this is the assumption that before a program or script exits
with non-zero status, it will have reported an error.
> Or in the "controlled exit" case:
>
> [...]
> error: pack-objects died with status 128
> error: failed to push some refs to 'ssh://example.com/foo/bar'
I sense that this quote is not complete. Did you strip some error message by
writing just "[...]"?
> - if (finish_command(&po))
> - return error("pack-objects died with strange error");
> - return 0;
> + status = finish_command(&po);
> + if (status > 0)
> + return error("pack-objects died with status %d", status);
> + return status;
Ideally, this should really just be
if (finish_command(&po))
return -1;
-- Hannes
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html