Re: [RFC PATCH] Makefile: new prove target for running the tests with TAP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Michael J Gruber wrote:

> Introduce a new make target "prove" which runs the tests via "prove"

I like it. :)

I've been using

	prove -j2 --shuffle t[0-9]*.sh

and would be happier to be able to dump GIT_PROVE_OPTS="-j2 --shuffle"
in my config.mak and just run "make prove" instead of that unwieldly
glob.

> RFC also because of lack of doc, and:
> 
> Currently, one can do
> 
> make -C t t6010-merge-base.sh
> 
> or even
> 
> make -C t t601*
> 
> which is cool but undocumented. If we want this with prove it requires more
> effort

Doesn't "prove t601*" work well for that use case already?

> --- a/t/Makefile
> +++ b/t/Makefile
[...]
> +prove: pre-clean
> +	@echo "*** prove ***"; GIT_CONFIG=.git/config $(PROVE) --exec '$(SHELL_PATH_SQ)' $(GIT_PROVE_OPTS) $(T) :: $(GIT_TEST_OPTS)
> +	$(MAKE) clean
> +
>  $(T):
>  	@echo "*** $@ ***"; GIT_CONFIG=.git/config '$(SHELL_PATH_SQ)' $@ $(GIT_TEST_OPTS)

Not about this patch, but is that GIT_CONFIG setting needed?  I would have
guessed rather that test-lib.sh would unset GIT_CONFIG as soon as possible.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]