Re: [PATCH 3/3] t5523: test push progress output to tty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King wrote:

> --- a/t/t5523-push-upstream.sh
> +++ b/t/t5523-push-upstream.sh
[...]
> @@ -72,7 +73,14 @@ test_expect_success 'push -u HEAD' '
>  	check_config headbranch upstream refs/heads/headbranch
>  '
>  
> -test_expect_success 'progress messages to non-tty' '
> +test_expect_success 'progress messages go to tty' '
> +	ensure_fresh_upstream &&
> +
> +	test_terminal git push -u upstream master >out 2>err &&
> +	grep "Writing objects" err
> +'

Missing TTY prerequisite.  (Do you think test_terminal should check
$prereq to prevent this?)

> @@ -88,4 +96,18 @@ test_expect_success 'progress messages to non-tty (forced)' '
>  	grep "Writing objects" err
>  '
>  
> +test_expect_success 'push -q suppresses progress' '
> +	ensure_fresh_upstream &&
> +
> +	test_terminal git push -u -q upstream master >out 2>err &&
> +	! grep "Writing objects" err
> +'

Likewise.

> +
> +test_expect_failure 'push --no-progress suppresses progress' '
> +	ensure_fresh_upstream &&
> +
> +	test_terminal git push -u --no-progress upstream master >out 2>err &&
> +	! grep "Writing objects" err
> +'

Likewise.

Regards,
Jonathan
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]