Re: [PATCH v4 11/15] daemon: report connection from root-process

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Erik Faye-Lund <kusmabite@xxxxxxxxx> writes:

> Report incoming connections from the process that
> accept() the connection instead of the handling
> process.
>
> This enables "Connection from"-reporting on
> Windows, where getpeername(0, ...) consistently
> fails.
>
> Signed-off-by: Erik Faye-Lund <kusmabite@xxxxxxxxx>
> ---
>  daemon.c |   72 ++++++++++++++++++++++++++++++-------------------------------
>  1 files changed, 35 insertions(+), 37 deletions(-)
>
> diff --git a/daemon.c b/daemon.c
> index 8a44fb9..1574f75 100644
> --- a/daemon.c
> +++ b/daemon.c
> @@ -516,38 +516,11 @@ static void parse_host_arg(char *extra_args, int buflen)
>  }
>  
>  
> -static int execute(struct sockaddr *addr)
> +static int execute(void)
>  {
> -...
> -		}
> -		loginfo("Connection from %s:%d", addrbuf, port);
> -		setenv("REMOTE_ADDR", addrbuf, 1);
> ...
> +	else {
> +		loginfo("[%"PRIuMAX"] Connection from %s:%d",
> +		    (uintmax_t)cld.pid, addrstr, port);
>  		add_child(&cld, addr, addrlen);

Hmm, loginfo() calls logreport() and adds the process information as
necessary to the output.  Wouldn't this patch give the pid information
twice?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]