Junio C Hamano <gitster@xxxxxxxxx> writes: > Neither the patch nor your suggestion makes much sense to me. With the > patch, the regexp is now > > ^(1969-12-31|1970-01-01) <time>(\.0+)? ([-+][0-2][0-9]):?([0-5][0-9]) > > so $3 is always 3 letters long (i.e. hour with sign), no? IOW, zoneoffset > is never divided by 100 by the original patch. > > What am I missing? Well, I was missing that without ':' strtol() goes through to parse $3$4 as a single integer, and the division was done to discard the minute part and parse it again. Calling strtol() twice only because some unusual input may have ':' there feels ugly, but now I understand why the patch is written that way, at least. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html