On Sunday 10 October 2010 23:48:58 SZEDER GÃbor wrote:
> 'git bisect replay' has a mandatory logfile argument, but the current
> implementation doesn't check whether the user has specified one. When
> the user omits the logfile argument, this leads to the following
> unhelpful error message:
>
> cannot read for replaying
>
> So, check for the mandatory argument first, and provide a more
> meaningful error message when it is omitted.
>
> Signed-off-by: SZEDER GÃbor <szeder@xxxxxxxxxx>
> ---
> git-bisect.sh | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/git-bisect.sh b/git-bisect.sh
> index 68fcff6..c21e33c 100755
> --- a/git-bisect.sh
> +++ b/git-bisect.sh
> @@ -343,6 +343,7 @@ bisect_clean_state() {
> }
>
> bisect_replay () {
> + test "$#" -eq 1 || die "No logfile given"
> test -r "$1" || die "cannot read $1 for replaying"
> bisect_reset
> while read git bisect command rev
While at it perhaps you could do something like:
bisect_replay () {
+ test "$#" -lt 1 || die "No logfile given"
+ test "$#" -gt 1 || die "Too many argument. Please give only one logfile."
test -r "$1" || die "cannot read $1 for replaying"
bisect_reset
while read git bisect command rev
Thanks,
Christian.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html