Junio C Hamano wrote: > Sven Eckelmann <sven.eckelmann@xxxxxx> writes: > > For each commit a shorter version of the name will be generated. This is > > either the truncated hash or the output of git-describe. The > > call to git-describe was only made with an empty shell variable instead > > of an actual commit hash. Thus it only described the current HEAD and > > not each commit we want to submit to cia.vc. > > > > Signed-off-by: Sven Eckelmann <sven.eckelmann@xxxxxx> > > --- > > I send this patch already two and four weeks ago and got no reaction. > > This is a resent in case it was forgotton. > > Although the computation of "rev" indeed looks wrong, I do not see it used > anywhere, so it might be a better patch to remove it ... wait, the code > does something funny to slurp everything into xml via ... > > context = locals() > context.update(globals()) > out = xml % context > > Yuck. > > Even though it has been my policy not to complain too loudly on stuff in > contrib/ part of the tree, I have to say that this is a bit too _cute_ for > my taste. > > Anyway, Ok, so it _is_ used. And it needs to be fixed. Yes, it is a little bit confusing when reading through it, but still it is used. :) > I was hoping that Eric who took over the maintainership of contrib/ciabot/ > directory in April would give his blessing sooner, without me having to > look at the script. > > Ack? Hm, just be sure, because I saw no other replies since this message: You expected reaction after that "Ack?" from Eric Raymond and not from me, or? Anyway, thanks for answering :) Kind regards, Sven
Attachment:
signature.asc
Description: This is a digitally signed message part.