Re: [TopGit PATCH 01/10] cat_file: take -i/-w parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



2010/10/9 Uwe Kleine-KÃnig <u.kleine-koenig@xxxxxxxxxxxxxx>:
> Hi Bert,
>
> On Fri, Oct 08, 2010 at 09:57:59AM +0200, Bert Wesarg wrote:
>> This changes the way how cat_file selects the source of the file. It
>> accepts an optional parameter which is either -i or -w and will react on this
>> instead of the branch name. tg-patch is updated accordingly and can now
>> accepts the current branch name as argument with -i or -w given.
>>
>> cat_file was also broken for the worktree case when we are not in the top level.
>>
>> Also, tg-patch allowed to be on the top-base branch, but -i and -w doesn't
>> make sense there too.
>>
>> Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx>
> doesn't apply anymore. ÂDo you care to fix and resend? ÂI think it's
> your own change to cat_file BTW ... :-)

Right, Sorry. I should have done a git fetch. Will resend now.

>
>
>> ---
>>
>> I will probably never understand why TopGit accepts to be on a top-base branch.
> /me shrugs.
>
>> I will probably never understand why TopGit not changes the cwd to the top level.
> I can imagine that strange things can happen then, but I don't have an
> example.
>
>> I will probably never understand why TopGit does not use the git-sh-setup.sh.
> I'm not sure this works in all cases. ÂAnd I think it's not sensibe as
> we don't have control over this file. ÂAnd what if it starts providing a
> function with the same name as one of our's?

It does already: die.

Regards,
Bert

>
> Best regards
> Uwe
>
h
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]