Re: [TopGit PATCH 09/10] [RFC] tg-patch: use ui diff when pager is active

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bert,


On Fri, Oct 08, 2010 at 09:58:07AM +0200, Bert Wesarg wrote:
> Signed-off-by: Bert Wesarg <bert.wesarg@xxxxxxxxxxxxxx>

can you tell me the motivation for this patch again?  It should go into
the commit log, too.

Thanks
Uwe

> ---
>  tg-patch.sh |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/tg-patch.sh b/tg-patch.sh
> index 9def6e5..dcce672 100644 tg-patch.sh
> --- a/tg-patch.sh
> +++ b/tg-patch.sh
> @@ -70,7 +70,12 @@ t_tree=$(pretty_tree "$name" $head_from)
>  if [ $b_tree = $t_tree ]; then
>  	echo "No changes."
>  else
> -	git diff-tree -p --stat $b_tree $t_tree
> +	# use the ui diff command when the pager is active
> +	diff_command=diff
> +	[ "x$GIT_PAGER_IN_USE" = "x1" ] ||
> +		diff_command=diff-tree
> +
> +	git $diff_command -p --stat $b_tree $t_tree
>  fi
>  
>  echo '-- '
> -- 
> 1.7.1.1067.g5aeb7
> 
> 

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]