On Thu, 2010-10-07 at 19:40 +0200, Matthieu Moy wrote:
> Jeff King <peff@xxxxxxxx> writes:
>
> > diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> > index efe9360..3b2dca0 100644
> > --- a/builtin/rev-list.c
> > +++ b/builtin/rev-list.c
> > @@ -147,8 +147,10 @@ static void show_commit(struct commit *commit, void *data)
> > }
> > } else {
> > if (revs->commit_format != CMIT_FMT_USERFORMAT ||
> > - buf.len)
> > - printf("%s%c", buf.buf, info->hdr_termination);
> > + buf.len) {
> > + fwrite(buf.buf, 1, buf.len, stdout);
> > + putchar(info->hdr_termination);
> > + }
> > }
> > strbuf_release(&buf);
> > } else {
>
> Sounds like a sane thing to do, yes.
Agreed. I could have sworn that printf() used standard C-strings which
terminate with %x00!
--
-Drew Northup
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html