On Thu, Oct 07, 2010 at 07:41:01PM +0200, Erik Faye-Lund wrote:
> > diff --git a/builtin/rev-list.c b/builtin/rev-list.c
> > index efe9360..3b2dca0 100644
> > --- a/builtin/rev-list.c
> > +++ b/builtin/rev-list.c
> > @@ -147,8 +147,10 @@ static void show_commit(struct commit *commit, void *data)
> > Â Â Â Â Â Â Â Â Â Â Â Â}
> > Â Â Â Â Â Â Â Â} else {
> > Â Â Â Â Â Â Â Â Â Â Â Âif (revs->commit_format != CMIT_FMT_USERFORMAT ||
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â buf.len)
> > - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â printf("%s%c", buf.buf, info->hdr_termination);
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â buf.len) {
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â fwrite(buf.buf, 1, buf.len, stdout);
> > + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â putchar(info->hdr_termination);
> > + Â Â Â Â Â Â Â Â Â Â Â }
> > Â Â Â Â Â Â Â Â}
> > Â Â Â Â Â Â Â Âstrbuf_release(&buf);
> > Â Â Â Â} else {
>
> This gives me a bit of a deja-vu: 1fb5fdd
>
> Also, fwriting like that to stdout might be a bit troublesome on
> Windows because the string won't end up going through our
> ANSI-emulation.
I don't know enough about the Windows output code paths to comment on
that. But this is almost identical to the fwrite in graph_show_commit
that we use for the "rev-list --graph" show path. If there is a fix, it
needs to be made to both places.
-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html