On Thu, Oct 7, 2010 at 07:55, Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> wrote:
> Ävar ArnfjÃrÅ Bjarmason <avarab@xxxxxxxxx> writes:
>
>> Change t/t5560-http-backend-noserver.sh to use the `X=Y && export X'
>> style instead of `export X=Y'. The latter doesn't work on all POSIX
>> shells.
>
> According to
>
> git grep '\<export [A-Za-z_]*='
>
> there seem to be a couple of other instances of this.
Yeah, the ones in Documentation/*.txt are OK IMO. The users reading
the docs probably don't have a shell old enough to complain about
this.
Likewise for contrib/hg-to-git/hg-to-git.py and gitweb/INSTALL.
These we probably want to fix:
git-am.sh: export GIT_MERGE_VERBOSITY=0
git-rebase.sh: export GIT_MERGE_VERBOSITY=1
git-stash.sh: export GIT_MERGE_VERBOSITY=0
and maybe this:
git-gui/lib/shortcut.tcl: puts $fd
"export PATH=[sq [file dirname $::_git]]:\$PATH &&"
This is the only other thing in the test suite:
t/t1509-root-worktree.sh:export GIT_DIR="$TRASH_DIRECTORY/.git"
t/t1509-root-worktree.sh:export GIT_WORK_TREE=/
t/t1509-root-worktree.sh:export GIT_DIR="$(echo
$TRASH_DIRECTORY|sed 's,^/,,')/.git"
But I didn't touch that since nobody runs that test anyway, and if
they do having a strict POSIX shell is the least of their problems.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html