Re: [PATCH] worktree: provide better prefix to go back to original cwd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 7, 2010 at 1:32 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
> Jonathan Nieder <jrnieder@xxxxxxxxx> writes:
>
>> Are there any examples to illustrate whether teaching --show-prefix to
>> do what your --worktree-to-cwd does would be a good or bad idea?
>> (Just curious.)
>
> Do these additions interact well with the notion of "we are in the working
> tree" vs "we are outside the working tree"? ÂEven when we happen to know
> via GIT_WORK_TREE that the root of the working tree is /var/tmp/junk, we
> should correctly diagnse that we are outside the working tree when we are
> in /var/tmp/, and require_work_tree should say "no you are not allowed to
> do this", no?

It should work as it does now. I don't change prefix calculation and
chdir() behavior. So when you're at /var/tmp, require_work_tree should
say no.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]