On Thu, 7 Oct 2010, Ãvar ArnfjÃrà Bjarmason wrote:
> On Wed, Oct 6, 2010 at 22:01, Jakub Narebski <jnareb@xxxxxxxxx> wrote:
>
> > + Â Â Â Â Â Â Â $cache ||= 'GitwebCache::SimpleFileCache';
> > + Â Â Â Â Â Â Â eval "require $cache";
>
> Just:
>
> eval { require $cache };
>
> Instead?
Wouldn't work correctly. We want to use 'require BAREWORD' version,
where BAREWORD is name of module, e.g. GitwebCache::SimpleFileCache,
and which makes Perl to search for GitwebCache/SimpleFileCache.pm
in @INC.
The 'require STRING' version loads file given by a *path*, and it
doesn't do library lookup.
>From `perldoc -f require`:
But if you try this:
$class = 'Foo::Bar';
require $class; # $class is not a bareword
#or
require "Foo::Bar"; # not a bareword because of the ""
The require function will look for the "Foo::Bar" file in the @INC array
and will complain about not finding "Foo::Bar" there. In this case you
can do:
eval "require $class";
Well, we could insert hooks into @INC, but I don't think we want to use
such hack.
--
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html